Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native support for STRING_AGG #1393

Open
wants to merge 18 commits into
base: staging
Choose a base branch
from
Open

Native support for STRING_AGG #1393

wants to merge 18 commits into from
+82 −3

Conversation

ryanmle2001
Copy link

Related to issue #1331

Process:

  • Added STRING_AGG to evadb.lark using LARK grammar per EvaDB new command documentation
  • Define new ExpressionType. AGGREGATION_STRING_AGG enum
  • Add AGGREGATION_STRING_AGG to aggregation_expression evaluate()
  • Define STRING_AGG aggregation in Batch class with error handlers for 1) invalid column input and 2) invalid delimiter
  • Unit tests

xzdandy
xzdandy reviewed Nov 28, 2023
View reviewed changes
script/test/test.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert the test.sh change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the access the permission is still changed. 100644 → 100755

xzdandy
xzdandy requested changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the unit tests they look good. I think we also need an integration test where we have the STRING_AGG in a SQL query to verify that it works from end to end.

@ryanmle2001
Copy link
Author

ryanmle2001 commented Nov 28, 2023 •
edited
Loading

Thanks for adding the unit tests they look good. I think we also need an integration test where we have the STRING_AGG in a SQL query to verify that it works from end to end.

Can you send some code pointers on writing an integration test here?

@ryanmle2001 ryanmle2001 reopened this Nov 29, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Dec 1, 2023

Thanks for adding the unit tests they look good. I think we also need an integration test where we have the STRING_AGG in a SQL query to verify that it works from end to end.

Can you send some code pointers on writing an integration test here?

@ryanmle2001 Here

evadb/test/integration_tests/long/test_huggingface_functions.py

Line 412 in bbfa483

def test_select_and_groupby_with_paragraphs(self):
is an example, replace the SEGMENT with the STRING_AGG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanmle2001 @xzdandy